Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files_sharing): select sharing in sidebar breaks Viewer focus trap #40273

Merged
merged 2 commits into from Sep 5, 2023
Merged

fix(files_sharing): select sharing in sidebar breaks Viewer focus trap #40273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f6101d
fix(files_sharing): select sharing in sidebar breaks Viewer focus trap
ShGKme Sep 5, 2023
cc7d155
chore: build assets
ShGKme Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 0 additions & 7 deletions apps/files_sharing/src/components/SharingInput.vue
View file
Open in desktop
Expand Up @@ -34,7 +34,6 @@
:clear-search-on-blur="() => false"
:user-select="true"
:options="options"
@open="handleOpen"
@search="asyncFind"
@option:selected="openSharingDetails">
<template #no-options="{ search }">
Expand All @@ -47,7 +46,6 @@
<script>
import { generateOcsUrl } from '@nextcloud/router'
import { getCurrentUser } from '@nextcloud/auth'
import { emit } from '@nextcloud/event-bus'
import axios from '@nextcloud/axios'
import debounce from 'debounce'
import NcSelect from '@nextcloud/vue/dist/Components/NcSelect.js'
Expand Down Expand Up @@ -156,11 +154,6 @@ export default {
},

methods: {
handleOpen() {
// Fix dropdown not opening when viewer is open, see https://github.com/nextcloud/viewer/pull/1319
emit('viewer:trapElements:changed', this.$refs.select.$el)
},

async asyncFind(query) {
// save current query to check if we display
// recommendations or search results
Expand Down
1 change: 0 additions & 1 deletion dist/2765-2765.js.map
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions dist/2765-2765.js → dist/894-894.js
View file
Open in desktop

Large diffs are not rendered by default.

0 dist/2765-2765.js.LICENSE.txt → dist/894-894.js.LICENSE.txt
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions dist/894-894.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/files_sharing-files_sharing_tab.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files_sharing-files_sharing_tab.js.map
View file
Open in desktop

Large diffs are not rendered by default.