Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appframework): Expose programmatic rate limiter #40288

Merged
merged 1 commit into from Sep 21, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Sep 6, 2023

Summary

We can't use rate limiting outside app framwork controllers. Now we can.

TODO

  • Do

Checklist

*
* @since 28.0.0
*/
interface IRateLimitExceededException extends Throwable {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deliberately exposed an interface not an implementation to avoid a https://en.wikipedia.org/wiki/Fragile_base_class

public function registerUserRequest(string $identifier,
int $userLimit,
int $userPeriod,
IUser $user): void;}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
IUser $user): void;}
IUser $user): void;
}

@ChristophWurst ChristophWurst requested review from nickvergessen and removed request for nickvergessen September 18, 2023 19:19
@nickvergessen
Copy link
Member

So, CS and we are ready to go

@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 19, 2023
@nickvergessen
Copy link
Member

Autoloader missing an update

Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing alias registration

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@nickvergessen nickvergessen merged commit 3b6a9cd into master Sep 21, 2023
35 of 38 checks passed
@nickvergessen nickvergessen deleted the feat/appframework/rate-limiter branch September 21, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement security
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants