Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CalDAV): check birthday calendar owner #40292

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix(CalDAV): check birthday calendar owner #40292

merged 1 commit into from
Sep 6, 2023

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Sep 6, 2023 •
edited
Loading

Summary

Add the correct 403 response for the DAV endpoint

Checklist

@miaulalala miaulalala added bug 3. to review Waiting for reviews labels Sep 6, 2023
@miaulalala miaulalala self-assigned this Sep 6, 2023
@miaulalala
Copy link
Contributor Author

/backport to stable27

@miaulalala
Copy link
Contributor Author

/backport to stable26

@miaulalala
Copy link
Contributor Author

/backport to stable25

@miaulalala
Copy link
Contributor Author

/backport to stable24

@miaulalala
Copy link
Contributor Author

/backport to stable23

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 6, 2023
View reviewed changes
apps/dav/lib/Server.php Dismissed Show dismissed Hide dismissed
@miaulalala
Copy link
Contributor Author

/backport to stable22

@miaulalala

This comment was marked as resolved.

Sign in to view
tcitworld
tcitworld approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, but shouldn't the CalendarHome's owner be the only one to be able to POST on it anyway?

ChristophWurst
ChristophWurst approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@joshtrichards joshtrichards added the feature: caldav Related to CalDAV internals label Sep 6, 2023
@miaulalala
fix(CalDAV): check birthday calendar owner
7eee1de 
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala merged commit 387cf9e into master Sep 6, 2023
38 checks passed
@miaulalala miaulalala deleted the fix/birthday-calendar branch September 6, 2023 16:54
This was referenced Sep 6, 2023
Merged
Merged
@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Sep 6, 2023
@backportbot-nextcloud

This comment was marked as resolved.

Sign in to view
@backportbot-nextcloud

This comment was marked as resolved.

Sign in to view
@AndyScherzinger AndyScherzinger mentioned this pull request Sep 6, 2023
Merged
@backportbot-nextcloud

This comment was marked as resolved.

Sign in to view
@backportbot-nextcloud

This comment was marked as resolved.

Sign in to view
This was referenced Sep 7, 2023
Closed
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@tcitworld tcitworld tcitworld approved these changes

@Altahrim Altahrim Altahrim approved these changes

@bigcat88 bigcat88 bigcat88 approved these changes

@provokateurin provokateurin provokateurin approved these changes

Assignees

@miaulalala miaulalala

Labels
3. to review Waiting for reviews backport-request bug feature: caldav Related to CalDAV internals
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@miaulalala @AndyScherzinger @ChristophWurst @tcitworld @Altahrim @bigcat88 @provokateurin @joshtrichards