Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable23] fix(ratelimit): Only use memory cache backend for redis #40307

Merged
merged 1 commit into from
Sep 7, 2023
Merged

[stable23] fix(ratelimit): Only use memory cache backend for redis #40307

merged 1 commit into from
Sep 7, 2023

Conversation

miaulalala
Copy link
Contributor

Manual backport of #40293

@nickvergessen @miaulalala
fix(ratelimit): Only use memory cache backend for redis
0fe4672 
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala requested review from a team, ArtificialOwl, sorbaugh and come-nc and removed request for a team September 6, 2023 16:49
@miaulalala miaulalala self-assigned this Sep 6, 2023
@miaulalala miaulalala added bug 3. to review Waiting for reviews labels Sep 6, 2023
@miaulalala
Copy link
Contributor Author

Failing test is samba:



Runtime:       PHP 7.4.21
--
41 | Configuration: /drone/src/tests/phpunit-autotest-external.xml
42 | Error:         No code coverage driver is available

@miaulalala miaulalala added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 7, 2023
@blizzz blizzz merged commit 323c2d8 into stable23 Sep 7, 2023
25 of 28 checks passed
@blizzz blizzz deleted the backport/stable23/40293 branch September 7, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc come-nc was automatically assigned from nextcloud/server-backend

Assignees

@miaulalala miaulalala

Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miaulalala @juliushaertl @skjnldsv @blizzz @nickvergessen