Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theming: Revert broken SVG optimization in default-source.svg #40329

Merged
merged 1 commit into from Sep 7, 2023

Conversation

provokateurin
Copy link
Member

Summary

f2afccf did some optimizations which inlined the included jpgs into the svg. This will make the image no longer update when the jpg files are updated and also bloats the svg itself. I'm pretty sure this was not intended.

Checklist

….svg

Signed-off-by: jld3103 <jld3103yt@gmail.com>
@provokateurin
Copy link
Member Author

/backport to stable27

@provokateurin provokateurin changed the title theming: Revert broken SVG optimization from f2afcc in default-source.svg theming: Revert broken SVG optimization in default-source.svg Sep 7, 2023
@provokateurin provokateurin merged commit eb55101 into master Sep 7, 2023
38 checks passed
@provokateurin provokateurin deleted the fix/theming-default-source-image branch September 7, 2023 14:52
@nickvergessen
Copy link
Member

The next automatic run will bring this back. So the script at https://github.com/nextcloud/server/blob/master/build/image-optimization.sh needs adjusting I guess (could start with ignoring the file for now, future step find a parameter that skips "embedding")

@provokateurin
Copy link
Member Author

Looking at the other "optinizations" it doesn't seem usefule to have that script. Changing the order of xml element attributes does nothing at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants