enh(db): provide database providers via IDB API #40423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
added
enhancement
3. to review
miaulalala
requested review from
ArtificialOwl,
icewind1991 and
sorbaugh
and removed request for
a team
kesselb
reviewed
Sep 14, 2023
ChristophWurst
added
the
pending documentation
|
This adds a new public API so it does need documentation |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
icewind1991
approved these changes
Sep 18, 2023
kesselb
approved these changes
Sep 18, 2023
ChristophWurst
approved these changes
Sep 18, 2023
ChristophWurst
approved these changes
Sep 18, 2023
miaulalala
force-pushed
the
enh/proved-db-as-string
branch
from
bc897df
to
fa13b72
Compare
To avoid leaking internals (OC), wrap the getDatabasePlatform and provide the associated constants fixes #30877 Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
force-pushed
the
enh/proved-db-as-string
branch
from
fa13b72
to
56419d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To avoid leaking internals (OC), wrap the getDatabasePlatform and provide the associated constants
Checklist
Screenshots before/after for front-end changesBackports requested where applicable (ex: critical bugfixes)