Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): CustomElementRender $el replacement bug #40465

Merged
merged 1 commit into from Sep 18, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 17, 2023

Context

Initially, I was trying to not wrap whatever is given to the CustomElementRender. But that means we have to update the $el reference.
Vue does not like this and lose reference when multiple updates are being done. We should avoid this, so I fallback to replacing the children and we just wrap into a span 馃し

Done

  • Fixed CustomElementRender
  • Make sure we don't run the render function of the systemTag action if there is none
  • Also fixed the border contrast on hover so it's still visible
    image

@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Sep 17, 2023
@skjnldsv skjnldsv requested review from susnux, artonge, lhsazevedo and a team September 17, 2023 12:36
@skjnldsv skjnldsv self-assigned this Sep 17, 2023
@skjnldsv skjnldsv requested review from Pytal and removed request for a team September 17, 2023 12:36
@skjnldsv
Copy link
Member Author

/compile amend /

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 18, 2023
Signed-off-by: John Molakvo忙 (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@skjnldsv skjnldsv merged commit e0c778f into master Sep 18, 2023
36 of 39 checks passed
@skjnldsv skjnldsv deleted the fix/customElementRendered branch September 18, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants