fix(files): CustomElementRender $el replacement bug #40465
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Initially, I was trying to not wrap whatever is given to the
CustomElementRender
. But that means we have to update the$el
reference.Vue does not like this and lose reference when multiple updates are being done. We should avoid this, so I fallback to replacing the children and we just wrap into a span 馃し
Done
CustomElementRender