Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load script and styles on setup page #40494

Merged
merged 1 commit into from Oct 31, 2023
Merged

load script and styles on setup page #40494

merged 1 commit into from Oct 31, 2023

Conversation

icewind1991
Copy link
Member

SetupController is not a real controller so it doesn't get middleware.

Fixes regression from #39867

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Sep 19, 2023
@icewind1991 icewind1991 added this to the Nextcloud 28 milestone Sep 19, 2023
@icewind1991 icewind1991 requested review from ChristophWurst, a team, ArtificialOwl, Fenn-CS and sorbaugh and removed request for a team September 19, 2023 08:52
@icewind1991 icewind1991 mentioned this pull request Sep 19, 2023
Merged
1 task
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish feature: install and update regression and removed 3. to review Waiting for reviews labels Oct 19, 2023
@icewind1991 @skjnldsv
load script and styles on setup page
1fffa3e 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@skjnldsv skjnldsv merged commit 43270c6 into master Oct 31, 2023
48 of 50 checks passed
@skjnldsv skjnldsv deleted the setup-script branch October 31, 2023 10:03
@kesselb kesselb mentioned this pull request Oct 31, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: install and update regression
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@icewind1991 @ChristophWurst @skjnldsv