Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store size in int|float for 32bit support #40501

Merged
merged 1 commit into from Sep 25, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Sep 19, 2023

Summary

On 32bits big files will have float sizes, so we cannot type file sizes as int.

Checklist

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added bug 3. to review Waiting for reviews feature: 32bits Bug specific to 32bits architectures labels Sep 19, 2023
@come-nc come-nc added this to the Nextcloud 28 milestone Sep 19, 2023
@come-nc come-nc self-assigned this Sep 19, 2023
@come-nc come-nc requested review from a team, ArtificialOwl and Fenn-CS and removed request for a team September 19, 2023 12:38
@come-nc
Copy link
Contributor Author

come-nc commented Sep 25, 2023

/backport to stable27

@come-nc
Copy link
Contributor Author

come-nc commented Sep 25, 2023

/backport to stable26

@come-nc come-nc merged commit dc347b3 into master Sep 25, 2023
40 checks passed
@come-nc come-nc deleted the fix/fix-int-size-in-files-scanner branch September 25, 2023 14:32
@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug feature: 32bits Bug specific to 32bits architectures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Downloads fail at 4GB with error "server returned wrong content-range" with 32bit server
3 participants