Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redirect to proper directory if file not found #40515

Merged
merged 1 commit into from Oct 4, 2023
Merged

fix: redirect to proper directory if file not found #40515

merged 1 commit into from Oct 4, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 19, 2023 •
edited by szaimen

Fix #32177
Fix #40104

  1. If you ask for a fileid in a dir
  2. And the fileid doesn't exists in that directory
  3. BUT the file only exists in one occurrence in another directory
  4. Then redirect to that file

@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Sep 19, 2023
@skjnldsv skjnldsv requested a review from a team September 19, 2023 19:01
@skjnldsv skjnldsv self-assigned this Sep 19, 2023
@skjnldsv skjnldsv requested review from ArtificialOwl, icewind1991 and Fenn-CS and removed request for a team September 19, 2023 19:01
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 19, 2023
View reviewed changes
apps/files/lib/Controller/ViewController.php Dismissed Show dismissed Hide dismissed
apps/files/lib/Controller/ViewController.php Fixed Show resolved Hide resolved
@skjnldsv skjnldsv mentioned this pull request Sep 24, 2023
Merged
@skjnldsv skjnldsv added this to In progress in Files to vue via automation Sep 26, 2023
@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 4, 2023

Ping everyone! 🙏

Altahrim
Altahrim approved these changes Oct 4, 2023
View reviewed changes
apps/files/lib/Controller/ViewController.php Outdated Show resolved Hide resolved
apps/files/lib/Controller/ViewController.php Fixed Show resolved Hide resolved
@skjnldsv
fix: redirect to proper directory if file not found
b05719c 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv merged commit ff9be6b into master Oct 4, 2023
38 of 39 checks passed
Files to vue automation moved this from In progress to Done Oct 4, 2023
@skjnldsv skjnldsv deleted the fix/redirect-if-wrong-dir branch October 4, 2023 14:37
@joshtrichards joshtrichards mentioned this pull request Dec 21, 2023
Merged
@skjnldsv skjnldsv mentioned this pull request Jan 26, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Altahrim Altahrim Altahrim approved these changes

@miaulalala miaulalala miaulalala approved these changes

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-backend

@schiessle schiessle Awaiting requested review from schiessle

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews enhancement feature: files
Projects
Files to vue
  
Done
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

[Bug]: url share not working [Bug]: internal links don't seem to get resolved properly
4 participants
@skjnldsv @Altahrim @miaulalala @max-nextcloud