Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use multipart copy for s3 #40531

Merged
merged 2 commits into from Sep 21, 2023
Merged

use multipart copy for s3 #40531

merged 2 commits into from Sep 21, 2023

Conversation

icewind1991
Copy link
Member

Switches to the multi part copies to support copying files >5GB (rename uses copy under the hood for ext s3)

Fixes #24540

Unfortunately my testing is limited by minio seemingly not having the 5GB limit on normal copy.

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Sep 20, 2023
@icewind1991 icewind1991 added this to the Nextcloud 28 milestone Sep 20, 2023
@icewind1991 icewind1991 requested review from a team, ArtificialOwl, Fenn-CS and sorbaugh and removed request for a team September 20, 2023 10:34
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
Copy link
Member Author

/backport to stable27

@icewind1991 icewind1991 merged commit 20b9a64 into master Sep 21, 2023
46 of 52 checks passed
@icewind1991 icewind1991 deleted the s3-multipart-copy branch September 21, 2023 14:02
@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 external storage: Cannot rename >5 GB files
4 participants