feat(files): properly format buttons, align mtime to the left and apply opacity based on file last modification #40583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
force-pushed
the
feat/f2v/dnd
branch
4 times, most recently
from
9ef05d6
to
e3b2af4
Compare
skjnldsv
force-pushed
the
feat/button-mtime
branch
3 times, most recently
from
b2a9ab7
to
7e6cfd3
Compare
…ly opacity based on file last modification Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
feat/button-mtime
branch
from
7e6cfd3
to
25e500b
Compare
artonge
reviewed
Sep 27, 2023
| @@ -389,6 +390,24 @@ export default Vue.extend({ | |||
| } | |||
| return this.t('files_trashbin', 'A long time ago') | |||
| }, | |||
| mtimeOpacity() { | |||
| // Whatever theme is active, the contrast will pass WCAG AA | |||
There was a problem hiding this comment.
So I assume that this accessible.
@JuliaKirschenheuter wasn't this remove from the old files view?
There was a problem hiding this comment.
Jan talked to me about it recently and said it was missing :)
but yes, it does pass WCAG AA (not AAA, which is ok for secondary text)
artonge
approved these changes
Sep 27, 2023
szaimen
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
padding-blockis used and not simple padding