[PoC] inline svg files #4059
Closed
[PoC] inline svg files #4059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saves loading a lot of resources. And since the css file is cached anyway this can save precious seconds. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
MorrisJobke
reviewed
Mar 26, 2017
| * @copyright Copyright (c) 2015, Hendrik Leppelsack <hendrik@leppelsack.de> | ||
| * @copyright Copyright (c) 2015, Jan-Christoph Borchardt <hey@jancborchardt.net> | ||
| * | ||
| * @license GNU AGPL version 3 or any later version |
There was a problem hiding this comment.
Could we add a message here saying: "This file is automatically generated"?
MorrisJobke
reviewed
Mar 26, 2017
| @@ -0,0 +1,32 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Also execute this on CI and throw an error if there is a change. 😉
There was a problem hiding this comment.
Yeah was thinking about that as well of course
MorrisJobke
requested changes
Mar 26, 2017
|
This alone removes 13 of 129 requests of the files app (10%) 🙌 |
7 tasks
|
May be an alternative to #3385 |
|
We would need a way that the »build process« for this is automated. Also, the icons.scss file has other things than just .svg links. :) |
|
Lets kill this. We can only do this properly if we would have a compile step or something for it (like scss or javascript). For now not worth it I think... |
|
Ref #1066 if we want to work on anything like that again. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves loading a lot of resources. And since the css file is cached
anyway this can save precious seconds.
Todo:
Files so far:
@ChristophWurst as discussed.