fix(theming): Make sure the footer is hidden if no content is rendered #40597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -95,7 +95,7 @@ | |||
| </h1> | |||
| <?php print_unescaped($_['content']); ?> | |||
| </main> | |||
| <?php if (isset($template) && $template->getFooterVisible()) { ?> | |||
| <?php if (isset($template) && $template->getFooterVisible() && ($theme->getLongFooter() !== '' || $_['showSimpleSignUpLink'])) { ?> | |||
Check notice
Code scanning / Psalm
RedundantConditionGivenDocblockType Note
susnux
force-pushed
the
fix/public-footer-empty-not-shown
branch
from
c6de3e1
to
8ef38ba
Compare
|
/backport to stable27 |
st3iny
approved these changes
Sep 23, 2023
Not touched that logic 😅 |
Merged
susnux
force-pushed
the
fix/public-footer-empty-not-shown
branch
from
8ef38ba
to
0f0085d
Compare
susnux
changed the title
ShGKme
approved these changes
Nov 1, 2023
Previously the footer was empty, but the backdrop was still shown. This hides the footer if no text content was defined. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/public-footer-empty-not-shown
branch
from
0f0085d
to
f62032e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously the footer was empty, but the backdrop was still shown.
This hides the footer if no text content was defined.
Screenshots
Checklist