fix(userstatus): Sync migration version number with app version #40614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
3. to review
ChristophWurst
requested review from
nickvergessen,
CarlSchwan and
Antreesy
nickvergessen
requested changes
Sep 25, 2023
apps/user_status/lib/Migration/Version1030Date20210809144824.php
Outdated
Show resolved
Hide resolved
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/userstatus/migration-version-number
branch
from
31ac640
to
cf3fadc
Compare
nickvergessen
approved these changes
Sep 26, 2023
ChristophWurst
added
4. to release
9 tasks
kesselb
approved these changes
Sep 26, 2023
|
mysql job timed out after 1h -> ignore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The migration version number was synced with server in #28403. The app was at 1.3.0. Now we are at 1.8.0 and it just feels wrong to continue the out-of-sync naming in #40564.
Renaming causes the migration to run again if it hasn't run already. It's adjusted to not cause an issue in that case.
I'm also open for other ideas that bring the versioning state into consistency.
TODO
Checklist