Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use correct unit for file sizes and fix user quota #40621

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix: Use correct unit for file sizes and fix user quota #40621

wants to merge 3 commits into from

Commits on Oct 11, 2023

  1. fix: Use correct unit for file sizes 

    We always used binary file sizes (base 2, meaning 2048 bytes = 2KiB),
but we added the wrong unit (we used the decimal (base 10) unit e.g. 2KB).

This fixes the user management showing a wrong quota.

Also the OC_Helper now supports base 10 and base 2 in `computerFileSize`,
for backwards compatibility it defaults to force even units like `KB` to be binary.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    8cf86ea View commit details
    Browse the repository at this point in the history

  2. fix(tests): Adjust tests for for correct file size unit 

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    23271d5 View commit details
    Browse the repository at this point in the history

  3. chore: Compile assets 

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    @susnux
    susnux committed Oct 11, 2023
    Configuration menu
    Copy the full SHA
    aad8513 View commit details
    Browse the repository at this point in the history