Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow PHP 8.3 #40630

Merged
merged 5 commits into from Sep 30, 2023
Merged

Allow PHP 8.3 #40630

merged 5 commits into from Sep 30, 2023
+8 −8

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Sep 26, 2023 •
edited

Summary

The test suites in #39796 are now passing on 8.3.
This PR allows PHP 8.3 in version check, and adds it to lint CI.

Checklist

@come-nc come-nc added enhancement 3. to review Waiting for reviews php Pull requests that update Php code labels Sep 26, 2023
@come-nc come-nc added this to the Nextcloud 28 milestone Sep 26, 2023
@come-nc come-nc self-assigned this Sep 26, 2023
@come-nc come-nc added the pending documentation This pull request needs an associated documentation update label Sep 26, 2023
@come-nc come-nc requested review from nickvergessen, ChristophWurst, a team, ArtificialOwl, icewind1991 and Fenn-CS and removed request for a team September 26, 2023 07:38
nickvergessen
nickvergessen approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropping PHP 8.0 in a follow up?

@come-nc
Copy link
Contributor Author

come-nc commented Sep 26, 2023

Dropping PHP 8.0 in a follow up?

No idea, was this decided for 28? Will it cause the same trouble as dropping 7.4? (ie there were no Nextcloud version supporting both debian stable and oldstable, making it hard to upgrade)

@nickvergessen
Copy link
Member

No idea, was this decided for 28? Will it cause the same trouble as dropping 7.4? (ie there were no Nextcloud version supporting both debian stable and oldstable, making it hard to upgrade)

Basically same story applies. We have to drop it in order to upgrade to library versions that support 8.3 and well it's out of security support in November, so helping people to update is the better option.

@tcitworld
Copy link
Member

Will it cause the same trouble as dropping 7.4?

8.0 was not used in major distributions according to https://repology.org/project/php/versions, except CentOS Stream 8 (where people can upgrade to 9 without issues)

@come-nc come-nc mentioned this pull request Sep 26, 2023
Closed
1 task
ChristophWurst
ChristophWurst approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello

@kesselb
Copy link
Contributor

kesselb commented Sep 29, 2023

Pushed ef003e5 to fix Error: Call to undefined function pcntl_signal()

@kesselb kesselb mentioned this pull request Sep 29, 2023
Closed
11 tasks
come-nc and others added 5 commits September 30, 2023 22:52
@come-nc @kesselb
Allow PHP 8.3 in version check
1daa881 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc @kesselb
Adding ini-file:development to 32bit CI
796bf32 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc @kesselb
Add 8.3 to lint CI and 32bits test suite
e20ba1c 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc @kesselb
Use latest shivammathur/setup-php in phpunit-32bits.yml
5586f2d 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@kesselb
ci: clear disable_functions to enable pcntl_signal
7e0ed6b 
When using ini-file development then disable_functions forbids pcntl_signal by default.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb merged commit 83cbd9c into master Sep 30, 2023
46 of 48 checks passed
@kesselb kesselb deleted the enh/enable-php-8.3 branch September 30, 2023 22:20
@ChristophWurst ChristophWurst mentioned this pull request Oct 2, 2023
Closed
3 tasks
@ChristophWurst
Copy link
Member

come-nc added the pending documentation label

add to https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_28.html#back-end-changes?

@come-nc come-nc mentioned this pull request Oct 12, 2023
Merged
@come-nc come-nc removed the pending documentation This pull request needs an associated documentation update label Nov 13, 2023
@rinchen
Copy link

rinchen commented Dec 20, 2023 •
edited

cron.php does not support php8.3

It reports this rather unusual statement on 27.1.5:
This version of Nextcloud is not compatible with PHP>=8.3.<br/>You are currently running 8.3.0.

EDIT: I did some clicking around and I was on the "latest" version of the docs but I found the 27.1.5 version and it's only good to 8.2. That got deployed via stable. The system we're using only has support for 7 so I had to use https://packages.sury.org/php/ repo which is always at the latest release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@kesselb kesselb kesselb approved these changes

@Fenn-CS Fenn-CS Fenn-CS approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews enhancement php Pull requests that update Php code
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Support PHP 8.3
7 participants
@come-nc @nickvergessen @tcitworld @kesselb @ChristophWurst @rinchen @Fenn-CS