Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable26] fix(dav): expand recurrences when searching #40632

Merged
merged 1 commit into from Oct 10, 2023
Merged

[stable26] fix(dav): expand recurrences when searching #40632

merged 1 commit into from Oct 10, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #40541

@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 26.0.8 milestone Sep 26, 2023
@st3iny st3iny added the 3. to review Waiting for reviews label Sep 26, 2023
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 26, 2023
@st3iny
fix(dav): expand recurrences when searching
ab0a39d 
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny
Copy link
Member

st3iny commented Sep 27, 2023 •
edited

Drone failure seem to be unrelated.

There was 1 failure:

1) Test\DB\QueryBuilder\FunctionBuilderTest::testConcatString with data set "2 columns: string real and int literal" (Closure Object (...))
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'12'
+'32'

/drone/src/tests/lib/DB/QueryBuilder/FunctionBuilderTest.php:62

@blizzz blizzz mentioned this pull request Oct 9, 2023
Merged
@blizzz
Copy link
Member

blizzz commented Oct 10, 2023

Drone failure seem to be unrelated.

There was 1 failure:

1) Test\DB\QueryBuilder\FunctionBuilderTest::testConcatString with data set "2 columns: string real and int literal" (Closure Object (...))
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'12'
+'32'

/drone/src/tests/lib/DB/QueryBuilder/FunctionBuilderTest.php:62

Went away with a re-run.

@blizzz blizzz merged commit 705944b into stable26 Oct 10, 2023
36 of 37 checks passed
@blizzz blizzz deleted the backport/40541/stable26 branch October 10, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@miaulalala miaulalala miaulalala approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst ChristophWurst is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: dav
Projects
None yet
Milestone
Nextcloud 26.0.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@st3iny @blizzz @miaulalala