Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backgroundjob): Schedule job after <timestamp> #40656

Merged
merged 1 commit into from Oct 2, 2023

Conversation

ChristophWurst
Copy link
Member

@ChristophWurst ChristophWurst commented Sep 27, 2023

Summary

For a planned execution in the future. Avoids a job that picked up again and again until it's time has come.

Credits go to

$query->update('jobs')
->set('last_run', $query->createNamedParameter($timestamp, IQueryBuilder::PARAM_INT))
->where($query->expr()->eq('id', $query->createNamedParameter($this->getId(), IQueryBuilder::PARAM_INT)));
$query->executeStatement();
and @nickvergessen.

TODO

  • Adjust API

Checklist

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update labels Sep 27, 2023
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then time to squash and merge?

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the feat/backgroundjob/schedule-job-after branch from e34a344 to 04ecc2a Compare September 29, 2023 08:29
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 29, 2023
@ChristophWurst ChristophWurst merged commit 0cb489d into master Oct 2, 2023
33 of 36 checks passed
@ChristophWurst ChristophWurst deleted the feat/backgroundjob/schedule-job-after branch October 2, 2023 09:30
@ChristophWurst ChristophWurst removed the pending documentation This pull request needs an associated documentation update label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants