fix(autocomplete): Fix missing user status on autocomplete endpoint

[nickvergessen]

• Discovered by @Antreesy when working with participant suggestions in Talk

Summary

Regression from 1be8362#diff-8a51ce62a02e28659acaa3f84252600107a22d2eb093d950f2c9c16fe6b96c8e
It seems the "empty string" default had confused @provokateurin but the status value was actually always an array, as per:

server/lib/private/Collaboration/Collaborators/UserPlugin.php

Lines 155 to 162 in 6427863

	$status = [
	'status' => $userStatus->getStatus(),
	'message' => $userStatus->getMessage(),
	'icon' => $userStatus->getIcon(),
	'clearAt' => $userStatus->getClearAt()
	? (int)$userStatus->getClearAt()->format('U')
	: null,
	];

I now added an integration test to confirm it's working and stays working. I left the default/empty value untouched as empty string and basically restored the array data when a status is present.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[provokateurin]

So it can be a string that is just the same object in JSON? I still can't make sense of this API

[nickvergessen]

So it can be a string that is just the same object in JSON? I still can't make sense of this API

No, it's a empty-string or an array as per OpenAPI doc block.

The JSON object is just used in Integration tests, because Behat can not handle nested arrays in TableNodes, so I json-encode the status array there

[provokateurin]

I see, but why the empty string instead of just null? This makes the API way more complex than it needs to be (although this is probably just for historical reasons).

[nickvergessen]

I see, but why the empty string instead of just null?

Because it was empty string since adding the values back in 2021 and yes I might have made a mistake there. But now clients could rely on it.

This makes the API way more complex than it needs to be (although this is probably just for historical reasons).

🤷🏼

[Antreesy]

tested against Talk app:

B	A