Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): encoded source path on actions requests #40756

Merged
merged 2 commits into from Oct 4, 2023
Merged

fix(files): encoded source path on actions requests #40756

merged 2 commits into from Oct 4, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 3, 2023 •
edited by ChristophWurst

Needs nextcloud-libraries/nextcloud-files#794
Fix regression from #40644

Fixes #40755

@skjnldsv skjnldsv added this to the Nextcloud 28 milestone Oct 3, 2023
@skjnldsv skjnldsv requested a review from kesselb October 3, 2023 14:52
@skjnldsv skjnldsv self-assigned this Oct 3, 2023
@skjnldsv skjnldsv added this to In progress in Files to vue via automation Oct 3, 2023
@kesselb kesselb mentioned this pull request Oct 3, 2023
Merged
6 tasks
@skjnldsv
fix(files): encoded source path on actions requests
d79e26b 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv marked this pull request as ready for review October 3, 2023 16:11
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 3, 2023
@skjnldsv skjnldsv requested review from artonge, a team, susnux, szaimen and Pytal and removed request for a team October 3, 2023 16:12
@kesselb kesselb mentioned this pull request Oct 3, 2023
Closed
8 tasks
@kesselb
Copy link
Contributor

kesselb commented Oct 3, 2023 

       ✗ generates file element with correct attributes when calling add() with file data
	Expected '1 KiB' to equal '1 KB'.
	    at Object.<anonymous> (apps/files/tests/js/filelistSpec.js:256:41)

Looks related to nextcloud-libraries/nextcloud-files#770 or nextcloud-libraries/nextcloud-files#769.

max-nextcloud
max-nextcloud approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and fixed the issue for me.

Thanks a lot for the blazing fast fix 🚀

@skjnldsv
fix(files): legacy humanFileSize tests
d591510 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 4, 2023
@skjnldsv skjnldsv merged commit 3f72582 into master Oct 4, 2023
29 of 31 checks passed
Files to vue automation moved this from In progress to Done Oct 4, 2023
@skjnldsv skjnldsv deleted the fix/encoded-source branch October 4, 2023 06:48
@kesselb kesselb mentioned this pull request Oct 28, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@artonge artonge artonge approved these changes

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@susnux susnux Awaiting requested review from susnux susnux was automatically assigned from nextcloud/server-frontend

@szaimen szaimen Awaiting requested review from szaimen szaimen was automatically assigned from nextcloud/server-frontend

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files technical debt
Projects
Files to vue
  
Done
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

[Bug]: [f2v] Spaces are double encoded in directory and filenames
4 participants
@skjnldsv @kesselb @artonge @max-nextcloud