Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(L10N): Support "Accept-Language: zh-Hans-CN" and alike #40808

Merged
merged 2 commits into from Oct 18, 2023

Conversation

c39cfbb3
Copy link
Contributor

@c39cfbb3 c39cfbb3 commented Oct 7, 2023

  • Resolves: #

Summary

Fall back for language codes like zh-Hans-CN if unsupported to zh_CN.

Checklist

@solracsf solracsf added the 3. to review Waiting for reviews label Oct 8, 2023
@susnux susnux requested review from a team, icewind1991, Altahrim, Fenn-CS and come-nc and removed request for a team October 10, 2023 23:38
@susnux susnux changed the title L10N/Factory: Support "Accept-Language: zh-Hans-CN" and alike fix(L10N): Support "Accept-Language: zh-Hans-CN" and alike Oct 10, 2023
@susnux
Copy link
Contributor

susnux commented Oct 10, 2023

Thank you for the pull request, looks like a good catch!

c39cfbb3 and others added 2 commits October 18, 2023 02:33
Signed-off-by: c39cfbb3 <145777845+c39cfbb3@users.noreply.github.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: c39cfbb3 <145777845+c39cfbb3@users.noreply.github.com>
@susnux
Copy link
Contributor

susnux commented Oct 18, 2023

Cypress unrelated.

@susnux susnux merged commit 1f8c21a into nextcloud:master Oct 18, 2023
35 of 39 checks passed
@welcome
Copy link

welcome bot commented Oct 18, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants