Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dynamic property timeFactory in ClientFlowLoginControllerTest #40829

Merged
merged 1 commit into from Oct 9, 2023
Merged

Fix Dynamic property timeFactory in ClientFlowLoginControllerTest #40829

merged 1 commit into from Oct 9, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Oct 9, 2023 •
edited

Summary

Fix 8.3 CI

See https://github.com/nextcloud/server/actions/runs/6451335744/job/17511839042

There were 15 errors:

1) Tests\Core\Controller\ClientFlowLoginControllerTest::testShowAuthPickerPageNoClientOrOauthRequest
Creation of dynamic property Tests\Core\Controller\ClientFlowLoginControllerTest::$timeFactory is deprecated

/__w/server/server/tests/Core/Controller/ClientFlowLoginControllerTest.php:99

Checklist

@come-nc
Fix Dynamic property timeFactory in ClientFlowLoginControllerTest
ee39a47 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added 3. to review Waiting for reviews technical debt labels Oct 9, 2023
@come-nc come-nc added this to the Nextcloud 28 milestone Oct 9, 2023
@come-nc come-nc self-assigned this Oct 9, 2023
@come-nc come-nc marked this pull request as ready for review October 9, 2023 08:34
@come-nc come-nc requested review from julien-nc, a team, ArtificialOwl, icewind1991 and Fenn-CS and removed request for a team October 9, 2023 08:34
@come-nc come-nc merged commit 2b7d01a into master Oct 9, 2023
40 of 41 checks passed
@come-nc come-nc deleted the fix/fix-dynamic-property-in-core-tests branch October 9, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-nc julien-nc julien-nc approved these changes

@Fenn-CS Fenn-CS Fenn-CS approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@come-nc @julien-nc @Fenn-CS