Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable26] Clear progress bar text when hiding it #40846

Merged
merged 1 commit into from Oct 10, 2023
Merged

[stable26] Clear progress bar text when hiding it #40846

merged 1 commit into from Oct 10, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

Backport of #40572

@danxuliu @backportbot-nextcloud
Clear progress bar text when hiding it
3a91a51 
When files are uploaded the progress bar text is set accordingly.
However, other operations that show the progress bar, like deleting
files, do not explicitly set any text. Due to that, when the progress
bar was shown again after uploading files the text did not match the
operation. To solve that now the text is cleared when the progress bar
is hidden (it is not cleared when it is shown as in some cases the text
is set already before showing the progress bar).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 26.0.8 milestone Oct 9, 2023
@blizzz blizzz mentioned this pull request Oct 10, 2023
Merged
@blizzz blizzz changed the title [stable26] [stable27] Clear progress bar text when hiding it [stable26] Clear progress bar text when hiding it Oct 10, 2023
@blizzz blizzz added the 3. to review Waiting for reviews label Oct 10, 2023
danxuliu
danxuliu approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

CI failure is unrelated.

@danxuliu danxuliu added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 10, 2023
@blizzz blizzz merged commit d6da782 into stable26 Oct 10, 2023
36 of 37 checks passed
@blizzz blizzz deleted the backport/40572/stable26 branch October 10, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz approved these changes

@danxuliu danxuliu danxuliu approved these changes

@susnux susnux Awaiting requested review from susnux

@szaimen szaimen Awaiting requested review from szaimen

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: files
Projects
None yet
Milestone
Nextcloud 26.0.8
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@blizzz @danxuliu