fix(federation): Use sharing.federation.allowSelfSignedCertificates config for all OCM requests
#40864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… config for all OCM requests Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
added
bug
3. to review
come-nc
approved these changes
Oct 12, 2023
mejo-
approved these changes
Oct 12, 2023
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
deleted the
bugfix/noid/use-allowSelfSignedCertificates-for-all-OCM-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The config already existed in many places, but was missed in these two, breaking it, because federation requests actually didn't work for self-signed certificates:
Checklist