Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix my-apps view on mobile #40871

Merged
merged 1 commit into from Oct 12, 2023
Merged

Fix my-apps view on mobile #40871

merged 1 commit into from Oct 12, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Oct 11, 2023

Address part of #36965

before

image

After

Aufzeichnung.2023-10-11.165237.mp4

@ShGKme
Copy link
Contributor

ShGKme commented Oct 11, 2023

Address part of #36965

Note: for tables it's also allowed to use horizontal scrolling

Exceptions apply to content that requires a two-dimensional layout, e.g. B. Images, maps, diagrams, videos, games, presentations, data tables and application interfaces in which the processing of content requires the permanent availability of toolbars.

https://ergebnis.bitvtest.de/pruefschritt/bitv-20-web/bitv-20-web-9-1-4-10-inhalte-brechen-um

@ShGKme
Copy link
Contributor

ShGKme commented Oct 11, 2023

I'm not sure this is a good approach to remove the data on a small screen. From the issue:

some information and functions are not available without users having to scroll horizontally

In this solution, we don't have the scroll, but some information is not available at all.

Maybe we can have a horizontal scrolling here, or switch to the grid layout (using isMobile util from nextcloud/vue)?

@JuliaKirschenheuter
Copy link
Contributor

In this solution, we don't have the scroll, but some information is not available at all.

Which functionality is missing?

Maybe we can have a horizontal scrolling here, or switch to the grid layout (using isMobile util from nextcloud/vue)?

The issue is that sticky header had not full width and action buttons were not fully available, like

Screenshot from 2023-10-12 10-50-04

@szaimen
Copy link
Contributor Author

szaimen commented Oct 12, 2023

I'm not sure this is a good approach to remove the data on a small screen. From the issue:

some information and functions are not available without users having to scroll horizontally

In this solution, we don't have the scroll, but some information is not available at all.

Actually I did not change the behaviour. Data was already removed before. I only adjusted the css so that it looks good on mobile :)

Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, tested again and it doesn't seems to be fixed ;(

Screenshot from 2023-10-12 10-52-39

@ShGKme
Copy link
Contributor

ShGKme commented Oct 12, 2023

Actually I did not change the behaviour. Data was already removed before. I only adjusted the css so that it looks good on mobile :)

Oh, sorry, I missed the "Before" section =D

But still, hiding the information seems to be the a11y issue here

@szaimen
Copy link
Contributor Author

szaimen commented Oct 12, 2023

But still, hiding the information seems to be the a11y issue here

Are you sure that was the problem here? I thought only the sticky header which is not going to the right?

@szaimen
Copy link
Contributor Author

szaimen commented Oct 12, 2023

/compile amend /

@ShGKme
Copy link
Contributor

ShGKme commented Oct 12, 2023

Are you sure that was the problem here? I thought only the sticky header which is not going to the right?

I'm not...

Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen
Copy link
Contributor Author

szaimen commented Oct 12, 2023

CI failure unrelated

@szaimen szaimen disabled auto-merge October 12, 2023 12:23
@szaimen szaimen merged commit 01d5979 into master Oct 12, 2023
37 of 40 checks passed
@szaimen szaimen deleted the enh/36965/fix-my-apps-view branch October 12, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants