New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix my-apps view on mobile #40871
Fix my-apps view on mobile #40871
Conversation
1400573
to
9434da5
Compare
Note: for tables it's also allowed to use horizontal scrolling
https://ergebnis.bitvtest.de/pruefschritt/bitv-20-web/bitv-20-web-9-1-4-10-inhalte-brechen-um |
I'm not sure this is a good approach to remove the data on a small screen. From the issue:
In this solution, we don't have the scroll, but some information is not available at all. Maybe we can have a horizontal scrolling here, or switch to the grid layout (using isMobile util from nextcloud/vue)? |
Which functionality is missing?
The issue is that sticky header had not full width and action buttons were not fully available, like |
Actually I did not change the behaviour. Data was already removed before. I only adjusted the css so that it looks good on mobile :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
9434da5
to
ee0ea4d
Compare
Oh, sorry, I missed the "Before" section =D But still, hiding the information seems to be the a11y issue here |
Are you sure that was the problem here? I thought only the sticky header which is not going to the right? |
1c7125f
to
52e4c7a
Compare
/compile amend / |
I'm not... |
Signed-off-by: Simon L <szaimen@e.mail.de> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
52e4c7a
to
8f66fbe
Compare
CI failure unrelated |
Address part of #36965
before
After
Aufzeichnung.2023-10-11.165237.mp4