Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change width for input field #40872

Merged
merged 1 commit into from Oct 17, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Oct 11, 2023

Change flex-direction to prevent horizontal scrolling

Summary

🏚️ Before 🏑 After
image Screenshot from 2023-10-12 14-02-03

Checklist

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to work for me:
image

apps/user_status/src/components/ClearAtSelect.vue Outdated Show resolved Hide resolved
@JuliaKirschenheuter JuliaKirschenheuter changed the title Change flex-direction for input field Change width for input field Oct 12, 2023
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine now in my testing.

However this detail still looks a bit weird, however could potentially be fixed in a follow-up:

image

@JuliaKirschenheuter
Copy link
Contributor Author

However this detail still looks a bit weird, however could potentially be fixed in a follow-up:

indeed, but, yes, this is another topic

@ShGKme
Copy link
Contributor

ShGKme commented Oct 16, 2023

Cypress and Drone tests are unrelated

@susnux
Copy link
Contributor

susnux commented Oct 16, 2023

Cypress and Drone tests are unrelated

Yes but the commits need to be squashed (fixup)

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36965-fix-status-message_dialog branch 2 times, most recently from 53ec1f7 to 6f9c8c4 Compare October 16, 2023 15:00
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@ShGKme
Copy link
Contributor

ShGKme commented Oct 17, 2023

Cypress fail unrelated

@JuliaKirschenheuter JuliaKirschenheuter merged commit 91118a5 into master Oct 17, 2023
40 of 42 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/36965-fix-status-message_dialog branch October 17, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants