Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix width of input on contacts menu #40873

Merged
merged 1 commit into from Oct 18, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

Summary

Fix width of input on contacts menu.

🏚️ Before 🏡 After
image Screenshot from 2023-10-11 16-34-08

Checklist

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this wait for #40749?

@JuliaKirschenheuter
Copy link
Contributor Author

Should this wait for #40749?

#40749 doesn't fix a width. I think there is no reason to wait

@szaimen
Copy link
Contributor

szaimen commented Oct 12, 2023

Should this wait for #40749?

#40749 doesn't fix a width. I think there is no reason to wait

Reason would be not to get into merge conflicts with #40749?

@szaimen szaimen mentioned this pull request Oct 16, 2023
8 tasks
@ShGKme
Copy link
Contributor

ShGKme commented Oct 16, 2023

Reason would be not to get into merge conflicts with #40749?

This is just a 1 line of unnecessary CSS change. IMO, we can merge this change as it is and port it to the mentioned PR

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36965-fix-search-contacts branch 2 times, most recently from b033297 to c8d8846 Compare October 16, 2023 14:17
@JuliaKirschenheuter
Copy link
Contributor Author

/compile amend /

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go now but conflicts

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested after the vue migration

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter
Copy link
Contributor Author

failed acceptance-header unrelated

@JuliaKirschenheuter JuliaKirschenheuter merged commit bd46aba into master Oct 18, 2023
40 of 41 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/36965-fix-search-contacts branch October 18, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants