Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Bump @nextcloud/password-confirmation from 4.0.1 to 5.0.0 #40874

Merged
merged 2 commits into from Oct 13, 2023
Merged

chore(deps): Bump @nextcloud/password-confirmation from 4.0.1 to 5.0.0 #40874

merged 2 commits into from Oct 13, 2023

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 11, 2023

Changes

5.0.0 - 2023-10-09

Fixed

  • Improve password confirmation dialog design and accessibility

Changed

  • Major update @nextcloud/vue to v8.0.0-beta.7

4.1.0 - 2023-10-09

Added

  • isPasswordConfirmationRequired(): boolean function to replace deprecated OC.PasswordConfirmation.requiresPasswordConfirmation()

Fixed

  • Fix compatibility with @nextcloud/l10n@^2

Changed

  • Add package.json/exports
  • Move to nextcloud-libraries organization
  • Add ESLint for linting files
  • Dependency updates

@ShGKme ShGKme added 3. to review Waiting for reviews dependencies labels Oct 11, 2023
@ShGKme ShGKme self-assigned this Oct 11, 2023
@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 11, 2023

Drone error unrelated 🥲

@ShGKme ShGKme force-pushed the chore/deps/nextcloud-password-confirmation branch from e56e597 to 119e80e Compare October 12, 2023 08:13
@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 12, 2023

Rebased onto master to resolve assets conflict, no other changes.

@ShGKme ShGKme enabled auto-merge October 12, 2023 08:13
@susnux
Copy link
Contributor

susnux commented Oct 12, 2023

cypress unrelated, seems to be due to Cypress 13 API change. Just rebase and fix the conflicts

@ShGKme
chore(deps): Bump @nextcloud/password-confirmation from 4.0.1 to 5.0.0
26c3885 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(assets): re-compile assets
50a7eba 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme force-pushed the chore/deps/nextcloud-password-confirmation branch from 119e80e to 50a7eba Compare October 12, 2023 18:02
@ShGKme
Copy link
Contributor Author

ShGKme commented Oct 12, 2023

Rebased onto master to resolve assets conflict, no other changes

@Pytal Pytal mentioned this pull request Oct 12, 2023
Merged
4 tasks
@susnux susnux disabled auto-merge October 13, 2023 00:52
@susnux susnux merged commit f103979 into master Oct 13, 2023
37 of 40 checks passed
@susnux susnux deleted the chore/deps/nextcloud-password-confirmation branch October 13, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@Pytal Pytal Pytal approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ShGKme @susnux @ChristophWurst @JuliaKirschenheuter @Pytal