Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix several admin settings problems #40887

Merged
merged 1 commit into from Oct 13, 2023
Merged

fix several admin settings problems #40887

merged 1 commit into from Oct 13, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Oct 12, 2023 •
edited

Address part of #36965

This is best reviewed like this: https://github.com/nextcloud/server/pull/40887/files?w=1

Before After
image image
image image
image image

@szaimen szaimen added this to the Nextcloud 28 milestone Oct 12, 2023
@szaimen szaimen mentioned this pull request Oct 12, 2023
Closed
@szaimen szaimen force-pushed the enh/36965/fix-admin-settings branch 4 times, most recently from efba975 to c0e0ea2 Compare October 12, 2023 14:07
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 12, 2023
@szaimen szaimen marked this pull request as ready for review October 12, 2023 14:11
JuliaKirschenheuter
JuliaKirschenheuter approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works, thank you!

ShGKme
ShGKme requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It broke the position of the "i" icon for me:

image

Including desktop layout

before after
image image

@szaimen
Copy link
Contributor Author

szaimen commented Oct 13, 2023

@ShGKme I cannot reproduce your problem. See my screen recording:

Aufzeichnung.2023-10-13.130255.mp4

@szaimen szaimen requested a review from ShGKme October 13, 2023 11:04
@ShGKme
Copy link
Contributor

ShGKme commented Oct 13, 2023

Same other issues with default apps

Basic settings Sharing (small issue with checkbox)
image image

@szaimen
Copy link
Contributor Author

szaimen commented Oct 13, 2023

Same other issues with default apps

@ShGKme did you compile the scss? It needs to be compiled first (is currently not commitwd to this branch)

@szaimen szaimen force-pushed the enh/36965/fix-admin-settings branch from c0e0ea2 to 407a3f4 Compare October 13, 2023 14:19
@szaimen
Copy link
Contributor Author

szaimen commented Oct 13, 2023

/compile amend /

@szaimen
Copy link
Contributor Author

szaimen commented Oct 13, 2023

/compile amend /

@szaimen @nextcloud-command
fix several admin settings problems
55c8481 
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen
Copy link
Contributor Author

szaimen commented Oct 13, 2023

CI failure unrelated

@szaimen szaimen disabled auto-merge October 13, 2023 16:22
@szaimen szaimen merged commit ba12ce8 into master Oct 13, 2023
37 of 39 checks passed
@szaimen szaimen deleted the enh/36965/fix-admin-settings branch October 13, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@ShGKme ShGKme ShGKme approved these changes

@susnux susnux Awaiting requested review from susnux

@Pytal Pytal Awaiting requested review from Pytal

Assignees
No one assigned
Labels
3. to review Waiting for reviews accessibility
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@szaimen @ShGKme @JuliaKirschenheuter