Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Append to body all selects inside of user table #40902

Merged
merged 1 commit into from Oct 17, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Oct 13, 2023

☑️ Resolves

🖼️ Screenshots

🏚️ Before

Peek 2023-10-11 10-18

🏡 After

Peek 2023-10-16 11-42

Checklist

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on your video, the select dropdown still overlaps?

Yes, but not so much as before.

@Pytal do you have some other ideas?

@Pytal
Copy link
Member

Pytal commented Oct 13, 2023

Based on your video, the select dropdown still overlaps?

Yes, but not so much as before.

Reply in the same comment !?🤪

@Pytal
Copy link
Member

Pytal commented Oct 13, 2023

@Pytal do you have some other ideas?

Pushed a fix :)

@JuliaKirschenheuter
Copy link
Contributor Author

Pushed a fix :)

Thank you!

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still looks a bit weird if there are not enough user rows but otherwise it works fine now :)

image

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36965-fix-nc-select-on-users-table branch from 9a43f4e to 985f98e Compare October 16, 2023 09:52
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with select great now, but there is an extra border in the table footer now now

apps/settings/src/components/Users/shared/styles.scss Outdated Show resolved Hide resolved
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/36965-fix-nc-select-on-users-table branch from 04c20e3 to ba0fadd Compare October 17, 2023 07:25
@JuliaKirschenheuter
Copy link
Contributor Author

Failed cypress is unrelated to PR

@JuliaKirschenheuter JuliaKirschenheuter merged commit ad7d20e into master Oct 17, 2023
38 of 40 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/36965-fix-nc-select-on-users-table branch October 17, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants