Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config.sample.php: fix incorrect theme name + add a missing ones #40926

Merged
merged 1 commit into from Oct 18, 2023
Merged

config.sample.php: fix incorrect theme name + add a missing ones #40926

merged 1 commit into from Oct 18, 2023

Conversation

joshtrichards
Copy link
Member

Summary

  • highcontrast no longer exists
  • Adds missing light-highcontrast
  • Adds missing opendyslexic
  • Re-orders alphabetically cuz 🤷‍♂️

TODO

  • ...

Checklist

@joshtrichards
config.sample.php: fix incorrect theme name + add a missing one
4a7f648 
Fixes #40908 

Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
@susnux
Copy link
Contributor

susnux commented Oct 15, 2023

I think the admin guide should also be adjusted https://github.com/nextcloud/documentation/blob/bfe646ec675beee40bb4a233f1eb2b1352c5438b/admin_manual/configuration_server/config_sample_php_parameters.rst?plain=1#L2853

@skjnldsv skjnldsv merged commit 1a425ab into master Oct 18, 2023
39 checks passed
@skjnldsv skjnldsv deleted the config-sample-theme-names-fix branch October 18, 2023 06:46
@skjnldsv skjnldsv added the pending documentation This pull request needs an associated documentation update label Oct 18, 2023
@ne0YT
Copy link

ne0YT commented Oct 18, 2023

@joshtrichards so it's not gonna be possible to set highcontrast while usign dark-lightmode of the system?

@joshtrichards
Copy link
Member Author

@susnux The contents of this PR will auto-propagate to that section of the Admin Manual

@ne0YT let's take that discussion back to your original Issue. I'll follow there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@solracsf solracsf solracsf approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: theming pending documentation This pull request needs an associated documentation update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow 'enforce_theme' => 'highcontrast', to system-following darkmode
5 participants
@joshtrichards @susnux @ne0YT @solracsf @skjnldsv