Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix profile visibility settings being too wide #40932

Merged
merged 2 commits into from Oct 17, 2023
Merged

fix profile visibility settings being too wide #40932

merged 2 commits into from Oct 17, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Oct 16, 2023 •
edited

Address part of #36965

Before After mobile After Desktop
image image image image
For my own testing 
docker run -it \
--name nextcloud-easy-test \
-p 8443:443 \
-e TRUSTED_DOMAIN=192.168.24.128 \
--volume="nextcloud_easy_test_npm_cache_volume:/var/www/.npm" \
-e SERVER_BRANCH=enh/36965/fix-account-settings \
-e COMPILE_SERVER=1 \
-e VIEWER_BRANCH=master \
ghcr.io/szaimen/nextcloud-easy-test:latest

@szaimen szaimen added this to the Nextcloud 28 milestone Oct 16, 2023
@szaimen szaimen mentioned this pull request Oct 16, 2023
Closed
@szaimen szaimen force-pushed the enh/36965/fix-account-settings branch 2 times, most recently from a569dff to 6dc1013 Compare October 17, 2023 11:40
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 17, 2023
@szaimen szaimen marked this pull request as ready for review October 17, 2023 11:54
ShGKme
ShGKme reviewed Oct 17, 2023
View reviewed changes
apps/settings/css/settings.scss Outdated Show resolved Hide resolved
apps/settings/css/settings.scss Outdated Show resolved Hide resolved
@szaimen szaimen requested a review from ShGKme October 17, 2023 14:13
JuliaKirschenheuter
JuliaKirschenheuter approved these changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@szaimen szaimen force-pushed the enh/36965/fix-account-settings branch from 6dc1013 to 6e91657 Compare October 17, 2023 14:56
@szaimen
Copy link
Contributor Author

szaimen commented Oct 17, 2023

/compile amend /

@szaimen @nextcloud-command
fix profile visibility settings being too wide
d5f0ba9 
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen
Copy link
Contributor Author

szaimen commented Oct 17, 2023

/compile amend /

@szaimen
Copy link
Contributor Author

szaimen commented Oct 17, 2023

/compile amend /

@szaimen @nextcloud-command
address review
d4415ba 
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen szaimen self-assigned this Oct 17, 2023
@szaimen
Copy link
Contributor Author

szaimen commented Oct 17, 2023

CI failure unrelated

@szaimen szaimen disabled auto-merge October 17, 2023 17:05
@szaimen szaimen merged commit a21d6c5 into master Oct 17, 2023
40 of 42 checks passed
@szaimen szaimen deleted the enh/36965/fix-account-settings branch October 17, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@ShGKme ShGKme ShGKme approved these changes

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@szaimen szaimen

Labels
3. to review Waiting for reviews accessibility
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@szaimen @AndyScherzinger @susnux @JuliaKirschenheuter @ShGKme