fix(settings): Account property scope actions #40938

Pytal · 2023-10-16T23:53:33Z

For [BITV] 9.4.1.2/6.4 - "Change scope" menus - Using the aria-label attribute on li elements along with role="presentation" is not allowed/recommended, as the aria-label output cannot be guaranteed. (1) #37130

Summary

Before	After

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Screenshots before/after for front-end changes
Documentation (manuals or wiki) has been updated or is not required
Backports requested where applicable (ex: critical bugfixes)

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Pytal added the 2. developing Work in progress label Oct 16, 2023

Pytal added this to the Nextcloud 28 milestone Oct 16, 2023

Pytal self-assigned this Oct 16, 2023

Pytal mentioned this pull request Oct 14, 2023

[BITV] 9.4.1.2/6.4 - "Change scope" menus - Using the aria-label attribute on li elements along with role="presentation" is not allowed/recommended, as the aria-label output cannot be guaranteed. (1) #37130

Closed

4 tasks

Pytal added 4 commits October 23, 2023 15:53

fix(settings): Remove aria-label on scope actions

18a2391

Signed-off-by: Christopher Ng <chrng8@gmail.com>

fix(settings): Name for scope button

a9fdc52

Signed-off-by: Christopher Ng <chrng8@gmail.com>

fix(settings): Styles for scope button

f0bb5e7

Signed-off-by: Christopher Ng <chrng8@gmail.com>

chore: compile assets

5a562a5

Signed-off-by: Christopher Ng <chrng8@gmail.com>

Pytal force-pushed the fix/a11y/change-scope-actions branch from 79966f6 to 5a562a5 Compare October 23, 2023 23:10

Pytal added 3. to review Waiting for reviews bug feature: settings accessibility and removed 2. developing Work in progress labels Oct 23, 2023

Pytal marked this pull request as ready for review October 23, 2023 23:15

Pytal requested review from susnux, JuliaKirschenheuter, ShGKme, szaimen and Fenn-CS October 23, 2023 23:15

Fenn-CS approved these changes Oct 23, 2023

View reviewed changes

Pytal merged commit 450985f into master Oct 24, 2023
42 of 43 checks passed

Pytal deleted the fix/a11y/change-scope-actions branch October 24, 2023 01:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(settings): Account property scope actions #40938

fix(settings): Account property scope actions #40938

Pytal commented Oct 16, 2023 •

edited

fix(settings): Account property scope actions #40938

fix(settings): Account property scope actions #40938

Conversation

Pytal commented Oct 16, 2023 • edited

Summary

Checklist

Pytal commented Oct 16, 2023 •

edited