Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(federation): Fix type and docs on ICloudFederationNotification in… #40965

Merged
merged 1 commit into from Oct 18, 2023
Merged

fix(federation): Fix type and docs on ICloudFederationNotification in… #40965

merged 1 commit into from Oct 18, 2023

Conversation

nickvergessen
Copy link
Member

…terface

Summary

  • Check the type on $providerId and be confused what OCP\Federation\id might be referring to:

grafik

Todo

  • Copy the doc block from the actual implementation

Checklist

@nickvergessen
fix(federation): Fix type and docs on ICloudFederationNotification in…
4f76c13 
…terface

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Oct 18, 2023
@nickvergessen nickvergessen self-assigned this Oct 18, 2023
@nickvergessen nickvergessen merged commit 5de36b6 into master Oct 18, 2023
38 of 39 checks passed
@nickvergessen nickvergessen deleted the bugfix/noid/fix-type-and-docs-on-interface branch October 18, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@susnux susnux susnux approved these changes

@provokateurin provokateurin provokateurin approved these changes

@andrey18106 andrey18106 andrey18106 approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews bug feature: federation
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nickvergessen @AndyScherzinger @susnux @provokateurin @andrey18106