Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix return type annotation of IShare::getExpirationDate #40969

Merged
merged 1 commit into from Oct 19, 2023
Merged

Fix return type annotation of IShare::getExpirationDate #40969

merged 1 commit into from Oct 19, 2023

Conversation

pulsejet
Copy link
Member

No description provided.

@pulsejet
Fix return type of IShare::getExpirationDate
c008464 
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
@pulsejet pulsejet added 3. to review Waiting for reviews php Pull requests that update Php code labels Oct 19, 2023
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 19, 2023
@skjnldsv skjnldsv merged commit a572a54 into master Oct 19, 2023
38 of 39 checks passed
@skjnldsv skjnldsv deleted the ishare-type branch October 19, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish php Pull requests that update Php code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pulsejet @nickvergessen @skjnldsv