Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Validation: replace non standard autocorrect with spellcheck #40978

Merged

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Oct 19, 2023

Summary

autocorrect attribute is not a standard and works only in Safari.

Replaced with HTML 5 spellcheck. Works in Safari since Safari supports HTML 5.

No visual changes.

See:

Checklist

@ShGKme ShGKme added this to the Nextcloud 28 milestone Oct 19, 2023
@ShGKme ShGKme self-assigned this Oct 19, 2023
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

`autocorrect` was actual for Safari long time ago when Safari didn't fully supported HTML 5 spellcheck.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@susnux susnux force-pushed the fix/37092/replace-non-standard-autocorrect-with-spellcheck branch from 76782b2 to 2d6cd78 Compare October 19, 2023 22:36
@susnux susnux merged commit 8ac6fe8 into master Oct 19, 2023
37 of 41 checks passed
@susnux susnux deleted the fix/37092/replace-non-standard-autocorrect-with-spellcheck branch October 19, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants