Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix placement of actions within unified search #40979

Merged
merged 1 commit into from Oct 20, 2023
Merged

Fix placement of actions within unified search #40979

merged 1 commit into from Oct 20, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

Summary

Before After
image Screenshot from 2023-10-19 14-41-19

Checklist

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Oct 19, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Oct 19, 2023
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Oct 19, 2023
Closed
szaimen
szaimen approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the screenshot but didnt test

@JuliaKirschenheuter
Copy link
Contributor Author

failed continuous-integration/drone/pr is not related

@JuliaKirschenheuter
Fix placement of actions within unified search
311d5c6 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@susnux susnux merged commit 8d907d8 into master Oct 20, 2023
39 of 42 checks passed
@susnux susnux deleted the fix/36965-fix-global-search branch October 20, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@Pytal Pytal Pytal approved these changes

@ShGKme ShGKme ShGKme approved these changes

@szaimen szaimen szaimen approved these changes

@artonge artonge Awaiting requested review from artonge

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews accessibility bug feature: search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JuliaKirschenheuter @susnux @Pytal @ShGKme @szaimen