Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML Validation: remove unnecessary roles #40980

Merged
merged 3 commits into from Oct 23, 2023
Merged

HTML Validation: remove unnecessary roles #40980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e8abfd
fix(core): remove unnecessary role=banner on top level header
ShGKme Oct 18, 2023
befec8c
fix(core): remove unnecessary role=contentinfo from page footer on login
ShGKme Oct 19, 2023
8159cdb
chore(assets): Re-compile assets
ShGKme Oct 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/css/guest.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion core/css/guest.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion core/css/guest.scss
View file
Open in desktop
Expand Up @@ -741,7 +741,7 @@ footer {
font-weight: bold;
}

&[role="contentinfo"] {
&.guest-box {
padding: 6px 24px;
margin-bottom: 1rem;

Expand Down
4 changes: 2 additions & 2 deletions core/templates/layout.guest.php
View file
Open in desktop
Expand Up @@ -33,7 +33,7 @@
<div class="wrapper">
<div class="v-align">
<?php if ($_['bodyid'] === 'body-login'): ?>
<header role="banner">
<header>
<div id="header">
<div class="logo"></div>
</div>
Expand All @@ -47,7 +47,7 @@
</main>
</div>
</div>
<footer role="contentinfo" class="guest-box">
<footer class="guest-box">
<p class="info">
<?php print_unescaped($theme->getLongFooter()); ?>
</p>
Expand Down
2 changes: 1 addition & 1 deletion core/templates/layout.user.php
View file
Open in desktop
Expand Up @@ -56,7 +56,7 @@
<?php if ($_['id-app-navigation'] !== null) { ?><a href="<?php p($_['id-app-navigation']); ?>" class="button primary skip-navigation"><?php p($l->t('Skip to navigation of app')); ?></a><?php } ?>
</div>

<header role="banner" id="header">
<header id="header">
<div class="header-left">
<a href="<?php print_unescaped($_['logoUrl'] ?: link_to('', 'index.php')); ?>"
aria-label="<?php p($l->t('Go to %s', [$_['logoUrl'] ?: $_['defaultAppName']])); ?>"
Expand Down