fix(tests): Only run tests on CI that are needed #40986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
force-pushed
the
fix/only-run-ci-that-is-needed
branch
from
1ed5fbe
to
725bbd6
Compare
susnux
requested review from
skjnldsv,
icewind1991,
juliushaertl,
nickvergessen and
pulsejet
nickvergessen
requested changes
Oct 19, 2023
susnux
force-pushed
the
fix/only-run-ci-that-is-needed
branch
from
725bbd6
to
e66b83b
Compare
|
Don't know enough about this part |
skjnldsv
approved these changes
Oct 20, 2023
susnux
force-pushed
the
fix/only-run-ci-that-is-needed
branch
from
e66b83b
to
22e9b2c
Compare
susnux
force-pushed
the
fix/only-run-ci-that-is-needed
branch
2 times, most recently
from
416d3ad
to
4ac25b2
Compare
|
I think this is good now :) |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/only-run-ci-that-is-needed
branch
from
4ac25b2
to
cbefae7
Compare
nickvergessen
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Do not run PHP unit tests when only JS code is changed, should save us some CI time.
TODO
node-test-summaryrequired instead ofjsunit,handlebarsandtest(node test)Checklist