Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): correct item height #41019

Merged
merged 1 commit into from Oct 21, 2023
Merged

fix(files): correct item height #41019

merged 1 commit into from Oct 21, 2023

Conversation

pulsejet
Copy link
Member

  1. grid: typo? The icon size is 160 - 44 + (44 / 2) = 138px
  2. non-grid: border is already included in height because the tr is a border-box (made this explicit to be safe)

comes from 16975ae

@pulsejet pulsejet added 3. to review Waiting for reviews files2vue labels Oct 20, 2023
@pulsejet pulsejet added this to the Nextcloud 28 milestone Oct 20, 2023
@skjnldsv
Copy link
Member

Yep, I must have failed a rebase, even the comment says 138 🙈

@skjnldsv skjnldsv added this to In progress in Files to vue via automation Oct 20, 2023
@susnux
Copy link
Contributor

susnux commented Oct 21, 2023

/compile amend

@susnux
Copy link
Contributor

susnux commented Oct 21, 2023

/compile amend

@pulsejet @nextcloud-command
fix(files): correct item height
4d578f3 
1. grid: typo? The icon size is 160 - 44 + (44 / 2) = 138px
2. non-grid: border is already included in height because the tr
   is a border-box (made this explicit to be safe)

Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
Copy link
Contributor

susnux commented Oct 21, 2023

drone unrelated

@susnux susnux merged commit 891097b into master Oct 21, 2023
37 of 40 checks passed
Files to vue automation moved this from In progress to Done Oct 21, 2023
@susnux susnux deleted the fix-files-vl-h branch October 21, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
Files to vue
  
Done
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pulsejet @skjnldsv @susnux