Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize UserMountCache::registerStorage #41057

Merged
merged 1 commit into from Nov 16, 2023
Merged

Conversation

icewind1991
Copy link
Member

Simplify the logic a bit and use less intermediate arrays

@icewind1991 icewind1991 added this to the Nextcloud 28 milestone Oct 23, 2023
@icewind1991 icewind1991 requested review from a team, blizzz, Altahrim and Fenn-CS and removed request for a team October 23, 2023 11:33
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
@blizzz blizzz mentioned this pull request Nov 6, 2023
@blizzz blizzz mentioned this pull request Nov 10, 2023
Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing required annotation, otherwise 👍

lib/public/Files/Config/ICachedMountInfo.php Show resolved Hide resolved
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah wait CI shows some issue:

PHP Fatal error:  Nesting level too deep - recursive dependency? in /home/runner/work/server/server/lib/private/Files/Config/UserMountCache.php on line 130

.htaccess Outdated Show resolved Hide resolved
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim Altahrim merged commit 23605d6 into master Nov 16, 2023
50 checks passed
@Altahrim Altahrim deleted the registermounts-opt branch November 16, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants