fix(workflowengine): Add an empty content when no flows are installed or configured #41089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
bug
3. to review
susnux
force-pushed
the
fix/workflow-empty-content
branch
from
fc45b9d
to
4d81032
Compare
skjnldsv
approved these changes
Oct 24, 2023
… or configured Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/workflow-empty-content
branch
from
4d81032
to
5b18099
Compare
|
Updated screenshots |
ShGKme
approved these changes
Oct 24, 2023
Pytal
approved these changes
Oct 24, 2023
|
Cypress unrelated -> logout was somehow changed (but unrelated to this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Views should not be empty so we add a NcEmptyContent for when there are no flows installed.
Moreover the headline for the configured flows was wrongly placed, it should not be within the element of the installed flows but on top of the configured views.
Screenshots
Checklist