fix(cypress): Also clone 3rdparty submodule to keep in sync for cypress tests #41135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
nickvergessen,
artonge,
skjnldsv,
Pytal and
max-nextcloud
susnux
force-pushed
the
fix/cypress-ci
branch
from
8dfae07
to
b0b7e0b
Compare
…ss tests Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/cypress-ci
branch
from
b0b7e0b
to
f3470cf
Compare
Pytal
approved these changes
Oct 26, 2023
skjnldsv
approved these changes
Oct 26, 2023
|
Failing node test seems unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If
libuses updated3rdpartylibraries but the shallow server is outdated (like now the server is 28 days old -> dependencies have been changed) it might lead to error 500 as the Nextcloud server can not find that changed dependencies.So we need to also pull submodules on Cypress init.
Checklist