Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create semantically right table for the "OAuth 2.0 clients" #41142

Merged
merged 1 commit into from Oct 27, 2023
Merged

Create semantically right table for the "OAuth 2.0 clients" #41142

merged 1 commit into from Oct 27, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter commented Oct 26, 2023 •
edited

Summary

  • Create semantically right "OAuth 2.0 clients" table
  • Adapt styles
Before After
Screenshot from 2023-10-26 17-30-08 Screenshot from 2023-10-27 09-50-58

Checklist

@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Oct 26, 2023
@JuliaKirschenheuter JuliaKirschenheuter requested review from Pytal, szaimen, susnux and ShGKme and removed request for Pytal October 26, 2023 15:31
@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Oct 26, 2023
ShGKme
ShGKme approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also replace <a>👁️</a> with a button?

@solracsf solracsf added this to the Nextcloud 28 milestone Oct 27, 2023
@JuliaKirschenheuter
Create semantically right table for the "OAuth 2.0 clients"
fbc9708 
Adapt styles

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/40869-Create_right_table_for_the_OAuth_2.0_clients branch from 08e1042 to fbc9708 Compare October 27, 2023 07:55
@susnux
Copy link
Contributor

susnux commented Oct 27, 2023

Drone unrelated

@JuliaKirschenheuter JuliaKirschenheuter merged commit 7727d12 into master Oct 27, 2023
40 of 41 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/40869-Create_right_table_for_the_OAuth_2.0_clients branch October 27, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susnux susnux susnux approved these changes

@ShGKme ShGKme ShGKme approved these changes

@szaimen szaimen Awaiting requested review from szaimen

@Pytal Pytal Awaiting requested review from Pytal

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

[BITV]: Create right table for the "OAuth 2.0 clients"
5 participants
@JuliaKirschenheuter @susnux @Pytal @ShGKme @solracsf