Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Turn off builds for pushes and merges to master/stable* and cancel parallel executions #41193

Merged
merged 3 commits into from Oct 30, 2023
Merged

ci: Turn off builds for pushes and merges to master/stable* and cancel parallel executions #41193

merged 3 commits into from Oct 30, 2023

Conversation

nickvergessen
Copy link
Member

No description provided.

@nickvergessen
ci: Specify concurrency to help with consecutive pushes
6def538 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Oct 30, 2023
@nickvergessen nickvergessen self-assigned this Oct 30, 2023
susnux
susnux reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@susnux susnux left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed and good, but we should keep node-tests and (later) phpunit tests run on push to master & stable* because otherwise the project code coverage can not be calculated.

There will only be partially values for PRs and if they only touch JS then only the JS coverage will be calculated.

But I think we should also calculate a overall project coverage to see whats missing to be tested, therefor we should run tests that count into code coverage on pushes to, at least, master.

.github/workflows/node-tests.yml Show resolved Hide resolved
@nickvergessen
ci: Turn off builds for pushes and merges to master/stable*
27a4ad4 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Copy link
Member Author

But I think we should also calculate a overall project coverage to see whats missing to be tested, therefor we should run tests that count into code coverage on pushes to, at least, master.

Reverted for now.

We could also just do it every night. I guess no one will look at it "live", so that should be totally fine and would help to reduce the run times even more.

@susnux
Copy link
Contributor

susnux commented Oct 30, 2023

We could also just do it every night. I guess no one will look at it "live", so that should be totally fine and would help to reduce the run times even more.

This sounds good!

@nickvergessen
ci: Only run note-tests once per day on branches
6cf8825 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen merged commit 9f89121 into master Oct 30, 2023
50 of 55 checks passed
@nickvergessen nickvergessen deleted the ci/noid/reduce-ci-waste branch October 30, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SystemKeeper SystemKeeper SystemKeeper approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny st3iny approved these changes

@provokateurin provokateurin provokateurin approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@susnux susnux Awaiting requested review from susnux

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nickvergessen @susnux @ChristophWurst @st3iny @SystemKeeper @provokateurin