feat(contactsmenu): Sort by user status #41266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ChristophWurst
added
3. to review
ChristophWurst
requested review from
Pytal,
nickvergessen,
st3iny,
kesselb,
hamza221 and
Antreesy
|
Something's weird with the name resolution:
This is supposed to be "Anna Admin" |
|
Otherwise it looks good:
|
Fixed. It's a remote user overlapping with a local UID. |
miaulalala
approved these changes
Nov 8, 2023
Pytal
approved these changes
Nov 8, 2023
ChristophWurst
force-pushed
the
feat/contactsmenu/user-status-sorting
branch
from
ab9bbe2
to
13685e6
Compare
ChristophWurst
added
4. to release
If user_status is not enabled, fall back to sorting by contact name. Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
feat/contactsmenu/user-status-sorting
branch
from
13685e6
to
71080a8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
List system contacts with a recent custom status message first sorted descending by the status change time, then all other contacts sorted ascending by their name.
If user_status is not enabled or nobody set their custom status recently, fall back to sorting by contact name ascending only.
TODO
Fix usage ofNot used anyway. API now falls back to old behavior if offset is supplied.\OCP\Contacts\ContactsMenu\IContactsStore::getContactswith pagination(avatars are only broken because automated tests deleted them …)
Follow-up
Checklist