Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable26] fix semaphore unguarding #41290

Merged
merged 1 commit into from Jan 15, 2024
Merged

[stable26] fix semaphore unguarding #41290

merged 1 commit into from Jan 15, 2024

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Nov 5, 2023

Manual backport of #41263 to stable26

@szaimen szaimen added bug 3. to review Waiting for reviews labels Nov 5, 2023
@szaimen szaimen added this to the Nextcloud 26.0.9 milestone Nov 5, 2023
@szaimen szaimen mentioned this pull request Nov 5, 2023
Merged
@szaimen
Copy link
Contributor Author

szaimen commented Nov 5, 2023

Needs an update to the baseline

@szaimen szaimen added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Nov 5, 2023
@szaimen szaimen marked this pull request as draft November 5, 2023 17:56
@blizzz blizzz mentioned this pull request Nov 13, 2023
Merged
@blizzz
Copy link
Member

blizzz commented Nov 16, 2023

moving to 26.0.10

@blizzz blizzz mentioned this pull request Dec 4, 2023
Merged
@blizzz
Copy link
Member

blizzz commented Dec 7, 2023

moving to 26.0.11

@kesselb kesselb removed their request for review December 7, 2023 15:37
tcitworld
tcitworld approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to have fixed php-fpm hanging for me.

@tcitworld tcitworld added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 3, 2024
@blizzz
Copy link
Member

blizzz commented Jan 11, 2024

It's still in draft state. @szaimen ?

@szaimen
Copy link
Contributor Author

szaimen commented Jan 11, 2024

It's still in draft state. @szaimen ?

Yes, see #41290 (comment)

@blizzz
Copy link
Member

blizzz commented Jan 12, 2024

Are you waiting for an auto-update?

@szaimen
Copy link
Contributor Author

szaimen commented Jan 12, 2024 •
edited

Are you waiting for an auto-update?

If you would update the psalm baseline, I would be greatful! 😉

But actually no customer has requested this backport afaik which is the main reason I didnt work on completing it yet...

@blizzz
Copy link
Member

blizzz commented Jan 12, 2024

It's still in draft state. @szaimen ?

Yes, see #41290 (comment)

Actually … the results looks wrong. It's as if github runs it with PHP 7 (but why). This is not our psalm result.

@DanScharon
Copy link

But actually no customer has requested this backport afaik which is the main reason I didnt work on completing it yet...

We haven't yet, because we saw there is this open pr scheduled for a release. But if necessary we would open an issue via portal.nextcloud.com 😄

@szaimen
Copy link
Contributor Author

szaimen commented Jan 12, 2024

So I tried to update the baseline but it seems like updating that is failing. See https://github.com/nextcloud/server/actions/runs/7502981657/job/20426751313. @blizzz any idea how to proceed with this PR?

@blizzz blizzz mentioned this pull request Jan 15, 2024
Merged
@szaimen
fix semaphore unguarding
c088709 
Signed-off-by: Simon L <szaimen@e.mail.de>
@szaimen
Copy link
Contributor Author

szaimen commented Jan 15, 2024

Seems to work. Thanks a lot for the help @come-nc ! :)

@szaimen szaimen marked this pull request as ready for review January 15, 2024 11:09
@szaimen szaimen requested a review from blizzz January 15, 2024 11:22
@szaimen
Copy link
Contributor Author

szaimen commented Jan 15, 2024

CI failure unrelated

@szaimen szaimen disabled auto-merge January 15, 2024 16:37
@szaimen szaimen merged commit 3d6b97c into stable26 Jan 15, 2024
38 of 39 checks passed
@szaimen szaimen deleted the backport/41263/stable26 branch January 15, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcitworld tcitworld tcitworld approved these changes

@come-nc come-nc come-nc approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@solracsf solracsf Awaiting requested review from solracsf

@kesselb kesselb Awaiting requested review from kesselb

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@szaimen szaimen

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 26.0.11
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@szaimen @blizzz @DanScharon @tcitworld @come-nc