Metadata must be set a editable for PROPPATCH #41390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * Disable modification of the displayname property for files and | ||
| * folders via PROPPATCH. See PROPFIND for more information. | ||
| */ | ||
| $propPatch->handle(self::DISPLAYNAME_PROPERTYNAME, function ($displayName) { |
Check notice
Code scanning / Psalm
MissingClosureParamType Note
ArtificialOwl
force-pushed
the
enh/noid/limit-proppatch-metadata
branch
from
8235cdc
to
9cac531
Compare
ArtificialOwl
force-pushed
the
enh/noid/limit-proppatch-metadata
branch
from
9cac531
to
76b44a5
Compare
|
cypress error not related |
Merged
ArtificialOwl
force-pushed
the
enh/noid/limit-proppatch-metadata
branch
2 times, most recently
from
1ebc2e1
to
e25ebe6
Compare
ArtificialOwl
force-pushed
the
enh/noid/limit-proppatch-metadata
branch
2 times, most recently
from
11395c9
to
8e4f8e9
Compare
|
cypress error does not seems related |
ArtificialOwl
force-pushed
the
enh/noid/limit-proppatch-metadata
branch
3 times, most recently
from
edd8494
to
b9f5552
Compare
artonge
reviewed
Nov 14, 2023
artonge
approved these changes
Nov 14, 2023
ArtificialOwl
force-pushed
the
enh/noid/limit-proppatch-metadata
branch
2 times, most recently
from
61a26fc
to
a460d61
Compare
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
blizzz
force-pushed
the
enh/noid/limit-proppatch-metadata
branch
from
a460d61
to
847c687
Compare
come-nc
approved these changes
Nov 14, 2023
| * @param string $key metadata key | ||
| * | ||
| * @inheritDoc | ||
| * @return int edit permission |
There was a problem hiding this comment.
Suggested change
| * @return int edit permission | |
| * @return IMetadataValueWrapper::EDIT_* edit permission level |
| @@ -133,7 +134,20 @@ public function getKnownMetadata(): IFilesMetadata; | |||
| * @param string $key metadata key | |||
| * @param string $type metadata type | |||
| * @param bool $indexed TRUE if metadata can be search | |||
| * @param int $editPermission remote edit permission via Webdav PROPPATCH | |||
There was a problem hiding this comment.
Suggested change
| * @param int $editPermission remote edit permission via Webdav PROPPATCH | |
| * @param IMetadataValueWrapper::EDIT_* $editPermission remote edit permission level via Webdav PROPPATCH |
| * (Webdav PROPPATCH) | ||
| * | ||
| * @param string $key metadata key | ||
| * @param int $permission remote edit permission |
There was a problem hiding this comment.
Suggested change
| * @param int $permission remote edit permission | |
| * @param IMetadataValueWrapper::EDIT_* $permission remote edit permission level |
| * | ||
| * @param string $key metadata key | ||
| * | ||
| * @return int |
There was a problem hiding this comment.
Suggested change
| * @return int | |
| * @return IMetadataValueWrapper::EDIT_* edit permission level |
| * set remote edit permission | ||
| * (Webdav PROPPATCH) | ||
| * | ||
| * @param int $permission edit permission |
There was a problem hiding this comment.
Suggested change
| * @param int $permission edit permission | |
| * @param IMetadataValueWrapper::EDIT_* $permission edit permission level |
| * get remote edit permission | ||
| * (Webdav PROPPATCH) | ||
| * | ||
| * @return int edit permission |
There was a problem hiding this comment.
Suggested change
| * @return int edit permission | |
| * @return IMetadataValueWrapper::EDIT_* edit permission level |
There was a problem hiding this comment.
let me do this on a separated PR, post merge
AndyScherzinger
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the implementation of metadata and its compatibility with webdav PROPPATCH request, and to avoid unexpected behavior, 2 things needs to be implemented:
throws exception on fail, might be better to just log a warning but keep the process running ?