fix(cypress): Make new-users test less flaky by using test isolation #41399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
nickvergessen,
skjnldsv,
Pytal and
max-nextcloud
susnux
force-pushed
the
fix/cypress-flaky-new-users
branch
from
5714018
to
37794f8
Compare
Pytal
approved these changes
Nov 14, 2023
susnux
force-pushed
the
fix/cypress-flaky-new-users
branch
from
37794f8
to
b8630ba
Compare
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/cypress-flaky-new-users
branch
from
b8630ba
to
b06951e
Compare
ShGKme
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use test isolation which should make the tests less flaky and also force click the buttons so we can ignore the scrolled state of the new users modal.
Checklist